Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add migration schematic for function-based providers #1005

Merged
merged 12 commits into from
Nov 21, 2024
Merged

feat: add migration schematic for function-based providers #1005

merged 12 commits into from
Nov 21, 2024

Conversation

davidlj95
Copy link
Owner

@davidlj95 davidlj95 commented Oct 28, 2024 •
edited
Loading

Issue or need

See parent's PR #1004

Proposed changes

Adds schematics for deprecated symbols introduced in #1004

To run the migration manually:

ng update @davidlj95/ngx-meta --name=tree-shakeable-manager-providers
# Or also (needs setting manually the version in `package.json`)
ng update @davidlj95/ngx-meta --from=1.0.0-beta.32 --migrate-only

Introduces copy/pasted non-public Angular schematic utilities for stability purposes.

Introduces utility to visit all Typescript files in a project.

Adds a script to build with watch mode schematic files. This way feedback loop is shorter when running the migration in an example app.

Quick reminders

  • 🤝 I will follow Code of Conduct
  • ✅ No existing pull request already does almost same changes
  • 👁️ Contributing docs are something I've taken a look at
  • 📝 Commit messages convention has been followed
  • 💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
  • 🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
  • ⚙️ API Report has been updated if API surface is altered.

@davidlj95 Graphite App
Copy link
Owner Author

davidlj95 commented Oct 28, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@davidlj95 davidlj95 mentioned this pull request Oct 28, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

📦 Bundle size (Angular v15)

Git ref: 2da33cf7d64628c20ed76d221b40ed805fbaa0ab

Module file Size Base size Difference
ngx-meta-core.mjs 3386 bytes (3.4KiB) 3386 bytes (3.4KiB) No change
ngx-meta-json-ld.mjs 198 bytes (198B) 198 bytes (198B) No change
ngx-meta-open-graph.mjs 804 bytes (804B) 804 bytes (804B) No change
ngx-meta-routing.mjs 373 bytes (373B) 373 bytes (373B) No change
ngx-meta-standard.mjs 739 bytes (739B) 739 bytes (739B) No change
ngx-meta-twitter-card.mjs 412 bytes (412B) 412 bytes (412B) No change
Total 5912 bytes (5.8KiB) 5912 bytes (5.8KiB) No change

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

📦 Bundle size (Angular v17)

Git ref: 2da33cf7d64628c20ed76d221b40ed805fbaa0ab

Module file Size Base size Difference
ngx-meta-core.mjs 3205 bytes (3.2KiB) 3205 bytes (3.2KiB) No change
ngx-meta-json-ld.mjs 219 bytes (219B) 219 bytes (219B) No change
ngx-meta-open-graph.mjs 1033 bytes (1.1KiB) 1033 bytes (1.1KiB) No change
ngx-meta-routing.mjs 394 bytes (394B) 394 bytes (394B) No change
ngx-meta-standard.mjs 943 bytes (943B) 943 bytes (943B) No change
ngx-meta-twitter-card.mjs 539 bytes (539B) 539 bytes (539B) No change
Total 6333 bytes (6.2KiB) 6333 bytes (6.2KiB) No change

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

📦 Bundle size (Angular v18)

Git ref: 2da33cf7d64628c20ed76d221b40ed805fbaa0ab

Module file Size Base size Difference
ngx-meta-core.mjs 3205 bytes (3.2KiB) 3205 bytes (3.2KiB) No change
ngx-meta-json-ld.mjs 219 bytes (219B) 219 bytes (219B) No change
ngx-meta-open-graph.mjs 1033 bytes (1.1KiB) 1033 bytes (1.1KiB) No change
ngx-meta-routing.mjs 394 bytes (394B) 394 bytes (394B) No change
ngx-meta-standard.mjs 943 bytes (943B) 943 bytes (943B) No change
ngx-meta-twitter-card.mjs 539 bytes (539B) 539 bytes (539B) No change
Total 6333 bytes (6.2KiB) 6333 bytes (6.2KiB) No change

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

📦 Bundle size (Angular v16)

Git ref: 2da33cf7d64628c20ed76d221b40ed805fbaa0ab

Module file Size Base size Difference
ngx-meta-core.mjs 3411 bytes (3.4KiB) 3411 bytes (3.4KiB) No change
ngx-meta-json-ld.mjs 193 bytes (193B) 193 bytes (193B) No change
ngx-meta-open-graph.mjs 804 bytes (804B) 804 bytes (804B) No change
ngx-meta-routing.mjs 379 bytes (379B) 379 bytes (379B) No change
ngx-meta-standard.mjs 739 bytes (739B) 739 bytes (739B) No change
ngx-meta-twitter-card.mjs 470 bytes (470B) 470 bytes (470B) No change
Total 5996 bytes (5.9KiB) 5996 bytes (5.9KiB) No change

@davidlj95 davidlj95 force-pushed the stacked/feat-add-migration-schematic-for-breaking-changes branch from 1013a16 to 8421152 Compare October 29, 2024 15:59
@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e0cacac) to head (2da33cf).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #1005   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           90        97    +7     
  Lines          440       537   +97     
  Branches        49        64   +15     
=========================================
+ Hits           440       537   +97

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@davidlj95 davidlj95 force-pushed the stacked/feat-add-migration-schematic-for-breaking-changes branch 2 times, most recently from 2b3a25f to cae4c01 Compare October 30, 2024 16:00
@davidlj95 davidlj95 mentioned this pull request Oct 30, 2024
Merged
@davidlj95 davidlj95 force-pushed the stacked/feat-add-tree-shakeable-manager-providers branch from 8d79461 to 1069d4e Compare October 31, 2024 14:56
@davidlj95 davidlj95 force-pushed the stacked/feat-add-migration-schematic-for-breaking-changes branch from cae4c01 to a419553 Compare October 31, 2024 14:56
@davidlj95 davidlj95 mentioned this pull request Oct 31, 2024
Merged
@davidlj95 davidlj95 force-pushed the stacked/feat-add-tree-shakeable-manager-providers branch from 1069d4e to 1c90565 Compare November 20, 2024 18:32
@davidlj95 davidlj95 force-pushed the stacked/feat-add-migration-schematic-for-breaking-changes branch from a419553 to bee8336 Compare November 20, 2024 18:32
@davidlj95 davidlj95 force-pushed the stacked/feat-add-tree-shakeable-manager-providers branch 2 times, most recently from ac10dd7 to 67eb5e5 Compare November 20, 2024 20:21
@davidlj95 davidlj95 force-pushed the stacked/feat-add-migration-schematic-for-breaking-changes branch from bee8336 to 6eaff2b Compare November 20, 2024 20:23
@davidlj95 davidlj95 force-pushed the stacked/feat-add-tree-shakeable-manager-providers branch from 67eb5e5 to 7dd298b Compare November 21, 2024 10:12
@davidlj95 davidlj95 force-pushed the stacked/feat-add-migration-schematic-for-breaking-changes branch from 6eaff2b to 009374d Compare November 21, 2024 10:13
Base automatically changed from stacked/feat-add-tree-shakeable-manager-providers to main November 21, 2024 11:10
@davidlj95 davidlj95 force-pushed the stacked/feat-add-migration-schematic-for-breaking-changes branch from 009374d to 6fe866b Compare November 21, 2024 12:02
@davidlj95 davidlj95 force-pushed the stacked/feat-add-migration-schematic-for-breaking-changes branch from 6fe866b to 2da33cf Compare November 21, 2024 12:04
@davidlj95 davidlj95 marked this pull request as ready for review November 21, 2024 12:13
@davidlj95 davidlj95 merged commit ebf0fb8 into main Nov 21, 2024
35 checks passed
@davidlj95 davidlj95 deleted the stacked/feat-add-migration-schematic-for-breaking-changes branch November 21, 2024 12:17
@davidlj95 davidlj95 changed the title feat: add migration schematic for breaking changes feat: add migration schematic for function-based providers Nov 21, 2024
davidlj95 added a commit that referenced this pull request Nov 21, 2024
@davidlj95
feat: add migration schematic for function-based providers (#1005)
d9ad305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidlj95